Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Better documentation build workflow from 2021 GA Hackathon #1987

Merged
merged 10 commits into from
May 2, 2022

Conversation

epassaro
Copy link
Member

@epassaro epassaro commented Apr 27, 2022

Description

This is the documentation workflow I submitted to the 2021 GitHub Actions Hackathon.

It was designed to mimic ReadTheDocs behavior as much as possible. In this PR I present a simplified version, more suitable for TARDIS (since we are not going to use things like deploying SemVer tags, for example) and easier to understand.

Consists of two different workflows: build_docs.yml and clean_docs.yml.

Usage

Once merged, we can expect the following behavior:

Motivation and context

A better/easier to understand documentation pipeline.

How has this been tested?

  • Testing pipeline.
  • Other.

Except for some minor details regarding to the TARDIS-specific implementation, these workflows were extensively tested since November 2021.

Notice this workflow uses the pull_request_target and this trigger can't be tested from this PR. Requires merging to see if it's working. You can see successful branch builds on my fork and a pull request example.

Examples

Type of change

  • Bug fix.
  • New feature.
  • Breaking change.
  • None of the above.

Checklist

  • My change requires a change to the documentation.
    • I have updated the documentation accordingly.
    • (optional) I have built the documentation on my fork following the instructions.
  • I have assigned and requested two reviewers for this pull request.

@codecov
Copy link

codecov bot commented Apr 27, 2022

Codecov Report

Merging #1987 (9b8387a) into master (6983bfa) will not change coverage.
The diff coverage is n/a.

❗ Current head 9b8387a differs from pull request most recent head 9f8aada. Consider uploading reports for the commit 9f8aada to get more accurate results

@@           Coverage Diff           @@
##           master    #1987   +/-   ##
=======================================
  Coverage   59.99%   59.99%           
=======================================
  Files          70       70           
  Lines        8111     8111           
=======================================
  Hits         4866     4866           
  Misses       3245     3245           

📣 Codecov can now indicate which changes are the most critical in Pull Requests. Learn more

@epassaro epassaro self-assigned this Apr 29, 2022
@epassaro epassaro merged commit 37a9769 into tardis-sn:master May 2, 2022
@isaacgsmith isaacgsmith mentioned this pull request May 3, 2022
8 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Status: Done
Status: Done
Development

Successfully merging this pull request may close these issues.

2 participants